[JENKINS-76334] Make P4 console annotations work with Jenkins 2.539+ CSP #250
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-76334
Testing done
I created a freestyle job, triggered a build, and put fake p4 output in both
$JENKINS_HOME/jobs/fs/builds/1/logand$JENKINS_HOME/jobs/fs/p4trigger.log.Details
That rendered well before and after this change. With this change, no more CSP violations.
Additionally, I disambiguated the element class names a bit with the plugin ID as prefix.
I also tested regular build log by generating output like this in a loop, to ensure it would work with live build logs.
Submitter checklist