Adding fixes to Message-Id header so that domain override is possible. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
requested changes
Jan 2, 2020
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
I request changes because of the pom.xml patch and usage of the old package. The suggested change looks reasonable to me, thanks!
added 3 commits
January 18, 2020 16:30
- Reverted pom.xml changes. - Moved EnhancedMessage into jenkins.plugins.mailer.tasks package. - Added @restricted attribute to the class level. - Added code comments for EnhancedMessage class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some e-mail servers reject e-mails sent from the Jenkins and think those are spam messages. Reason is that Message-Id header contains some local domain and does not correspond with server's domain name. The solution is to override domain on plugin level so that e-mail server will think this is an internal mail sent and do not put it into junk folder.