Update to make use of display-url-api plugin #17
Conversation
| } else { | ||
| String line = colorForBuildResult(message); | ||
| if (line == message) { // line didn't contain a build result | ||
| if (line.equals(message)) { // line didn't contain a build result |
There was a problem hiding this comment.
What if line is null? I was elsewhere advised to use comparisons rather than .equals() with a risk of NPE (or make the nullness checks explicit).
|
@i386 : is this PR still valid in its premise? The plugin seems to compile over the past years, and this PR mostly seems to bring Java style fixes and one functional change (number of args for |
|
Is this PR still valid ? |
Ideally this PR would be resurrected: jenkinsci/instant-messaging-plugin#15 |
4 participants
Allows ircbot-plugin to compile against jenkinsci/instant-messaging-plugin#15
@jenkinsci/code-reviewers