Adding two features, custom colorizing styles and scope of notifications

[scttdavs]

Adding two new features to the plugin (tests and javadoc included)

Scope of Notifications

• send a command to jenkins, along with some usernames. The reply will be private messages to the usernames you passed through (instead of to the public channel)
• syntax is !jenkins botsnack bugs only scttdavs, foo, bar would return private messages to scttdavs, foo and bar.

Custom Colorizor Colors

• set custom colors for regex patterns (that you pass through) and save them as a setting only for the user that set it.
• can also clear a previous setting
• syntax is !jenkins set color <pattern> BLUE and to clear !jenkins set color <pattern> CLEAR
• so any future messages that contain a match for <pattern> will now be blue.
• great for overriding current colors for FAILURE and SUCCESS (for example)

[kutzi]

please avoid star imports

[kutzi]

I wonder what the usecase for the notification scope is?
Why would I want to have the notification send to certain persons on the channel, only?

If I would want a answer only to me, I can already a private conversation with the bot

[kutzi]

Isn't it a bit oversized - i.e. feature creep - to have a color scheme per user per freely configurable pattern?

I understand that you would want to configure the color schemes, but wouldn't it be enough to configure it globally (or per channel)?

[kutzi]

I really appreciate your efforts here!
But I think we need to talk about, what are the use cases here and what is really needed.

In terms of features I always prefer the 'less is more' philosophy.

[scttdavs]

Hi Christoph, thanks for taking a look at this so quickly! I'll let others chime in here when appropriate, but in response to:

I wonder what the usecase for the notification scope is?

This could be used so:

• only the people who worked on said feature/project receive the message about it.
• users have more options in who sees a response rather than the whole channel
• the channel is cleaner and less full of clutter

[jenkinsadmin]

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

[jimklimov]

Hello, this PR sounds like a neat idea, but there were quite a few review comments from @kutzi that were not addressed over the past 3+ years. Would the OP (or anyone else willing to fork) follow up on bringing it into shape?