Skip honor refspec test if env is an empty value#1023
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Jan 8, 2021
Merged
Skip honor refspec test if env is an empty value#1023MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite merged 1 commit intojenkinsci:masterfrom
Conversation
Fixes an array out of bounds when the environment variable being tested is an empty string. The test is checking that the variable is correctly expanded in the refspec but is not designed to test the case where the string is empty. It is possible to create a refspec that would work with the empty string value of the environment variable, but it is more complicated and does not add value to the scenarios evaluated by the test. The plugin bom tests of the most recent git plugin release are failing because the plugin bom test environment has the value of the environment variable `USER` as the empty string.
12 tasks
Member
|
(for jenkinsci/bom#393) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix array bounds exception in test run by PCT
Fixes an array out of bounds exception when the environment variable being tested is an empty string. The test is checking that the variable is correctly expanded in the refspec but is not designed to test the case where the expanded string is empty. Testing for an empty string expansion does not add enough value to the already existing tests.
Checklist
Types of changes
Further comments
It is possible to create a refspec that would work with the empty string value of the environment variable, but it is more complicated and does not add value to the scenarios evaluated by the test.
The plugin bom tests of the most recent git plugin release are failing because the plugin bom test environment has the value of the environment variable
USERas the empty string.See #1013 (comment) for more details