fix: Show button also when job-specific permissions are used#37
Open
mythsunwind wants to merge 1 commit intomasterfrom
Open
fix: Show button also when job-specific permissions are used#37mythsunwind wants to merge 1 commit intomasterfrom
mythsunwind wants to merge 1 commit intomasterfrom
Conversation
6 tasks
|
Hi @mythsunwind any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Testing done
@piyugit reported that they experiencing issues with the latest version of the Flaky Tests plugin due to the "Deflake this build" option no longer being visible on jobs with job-specific permissions. I try to not only check Jenkins.get().hasPermission(Item.BUILD) but also run.getParent().hasPermission(Item.BUILD) now which should give me the job (job is parent of run) and then check for permissions there.
Submitter checklist