Skip to content

fix: Show button also when job-specific permissions are used#37

Open
mythsunwind wants to merge 1 commit intomasterfrom
job-specific-permissions
Open

fix: Show button also when job-specific permissions are used#37
mythsunwind wants to merge 1 commit intomasterfrom
job-specific-permissions

Conversation

@mythsunwind
Copy link
Contributor

Testing done

@piyugit reported that they experiencing issues with the latest version of the Flaky Tests plugin due to the "Deflake this build" option no longer being visible on jobs with job-specific permissions. I try to not only check Jenkins.get().hasPermission(Item.BUILD) but also run.getParent().hasPermission(Item.BUILD) now which should give me the job (job is parent of run) and then check for permissions there.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@piyugit
Copy link

piyugit commented Nov 20, 2024

Hi @mythsunwind, I tested #37 , but the deflake option is still not visible to me even after manually loading it into the Jenkins. below are my permission level

1# We are part of QA group where we have all permissions see image=>
image
2# this is a overall permission structure (QA is a separate folder space of QA users)
image

It is only working even on the latest published version when QA folder/group got the access below
image

@piyugit
Copy link

piyugit commented Dec 9, 2024

Hi @mythsunwind any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants