Allow names of build parameters to be configurable#11
Open
ctran wants to merge 1 commit intojenkinsci:masterfrom
Open
Allow names of build parameters to be configurable#11ctran wants to merge 1 commit intojenkinsci:masterfrom
ctran wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Contributor
|
Do you mind rebasing this? |
Author
|
Will do. |
scpeters
reviewed
May 31, 2019
src/main/java/com/google/jenkins/flakyTestHandler/plugin/deflake/DeflakeAction.java
Outdated
Show resolved
Hide resolved
This can be useful when using failsafe plugin where the maven parameters has to be `failsafe.rerunFailingTestsCount` or when dot is not allowed in build parameter names.
Author
|
Looks like one of the tests failed on windows, similar to the failure on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful when using failsafe plugin where the maven parameters
has to be
failsafe.rerunFailingTestsCountor when dot is not allowedin build parameter names.