Skip to content

Conversation

@panicking
Copy link
Contributor

@panicking panicking commented Dec 20, 2025

Related to #61

Navigate the node to find the first one that show the error. This limit the log to the minimal in the pipeline.

Testing done

This done on multistage pipeline, where the log was printed to check if was correspoding to the the expected one

@panicking panicking requested a review from a team as a code owner December 20, 2025 11:22
@panicking panicking force-pushed the add-flow-node-log branch 3 times, most recently from 86ae017 to a36e92d Compare December 21, 2025 10:48
In complex pipeline we can find the node that generate the
error and just get that one back to the ErrorExplainer.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
@panicking
Copy link
Contributor Author

@jenkinsci/explain-error-plugin-developers Can I ask to use the rebase and merge without squash? It's important for people that join the project to understand each commit and the reason why they get splitted.

@shenxianpeng
Copy link
Member

Thanks for your suggestion. Currently, our pull request merge messages are set as follows:

image

For squash merges, we chose the default commit message option "Pull request title and description" instead of "Pull request title and commit details", as it seems easier to provide a useful description here than in individual commit messages. Additionally, many people tend to write commit messages without a detailed body.

I understand your point. We can consider doing this in cases when individual commits is important. For most PRs, however, squash merges help keep the main branch history cleaner.

@shenxianpeng shenxianpeng added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants