Skip to content

Try to retrieve dynamic axis value from Jenkins global properties straight away#6

Open
poolik wants to merge 1 commit intojenkinsci:masterfrom
poolik:master
Open

Try to retrieve dynamic axis value from Jenkins global properties straight away#6
poolik wants to merge 1 commit intojenkinsci:masterfrom
poolik:master

Conversation

@poolik
Copy link
Member

@poolik poolik commented Sep 16, 2016

This makes sure that if the dynamic value comes from Jenkins global variable then the matrix job will have active configurations correctly set / shown right away. Otherwise before the build has run (or after a restart) the active configurations of the matrix job won't reflect the dynamic axis values as they are only computed during the first build.

Potentially could expand this to try to load the value from System.getenv() as well.

…aight away

This makes sure that if the dynamic value comes from Jenkins global variable then the matrix job will have active configurations correctly set / shown right away. Otherwise before the build has run (or after a restart) the active configurations of the matrix job won't reflect the dynamic axis values as they are only computed during the first build.

Potentially could expand this to try to load the value from System.getenv() as well.
@poolik
Copy link
Member Author

poolik commented Sep 23, 2016

@oleg-nenashev perhaps you could take a look and provide feedback or merge?

@poolik
Copy link
Member Author

poolik commented Oct 17, 2016

@oleg-nenashev a gentle reminder of this open pull request, hopefully you can find the time to review.

@oleg-nenashev
Copy link
Member

Hmm, thanks for the ping.
I didn't even remember I'm somehow involved into this plugin.
Likely I've requested ownership at some point

@oleg-nenashev
Copy link
Member

I'd say it's rather an architecture bug in the plugin.
The field must be always calculated dynamically on the build startup && it should not be persisted in builds since parallel runs are going to bork the build process (IIRC it is known issue). There is also no guarantee that the global variable variable won't be misused in such case.

A proper fix would be to add dynamic calculation of the layout for UI. Otherwise your project may display outdated value if somebody sets a global variable, then configures the job and modifies the property again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants