Skip to content

Conversation

@lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Nov 30, 2025

This PR puts the slow image build test after the quicker ones (for quicker feedback), uses IMAGE_TAG instead of IMAGE_NAME in the test descriptions (as only the tag/jdk changes), and improve the description of the test building an image with custom build args.

Before:

Describing [jenkins/ssh-agent:nanoserver-ltsc2022-jdk21] image is present
<...>
Describing [jenkins/ssh-agent:nanoserver-ltsc2022-jdk21] build args

After:

Describing [nanoserver-ltsc2022-jdk21] image can be built
Describing [nanoserver-ltsc2022-jdk21] image can be built with custom build args

Extracted from:

Testing done

CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@lemeurherve lemeurherve marked this pull request as ready for review November 30, 2025 11:33
@lemeurherve lemeurherve requested a review from a team as a code owner November 30, 2025 11:33
@lemeurherve lemeurherve changed the title chore(windows/tests): reorder and improve desscriptions chore(windows): reorder tests and improve their descriptions Nov 30, 2025
@lemeurherve lemeurherve changed the title chore(windows): reorder tests and improve their descriptions chore: reorder Windows tests and improve their descriptions Nov 30, 2025
@timja timja merged commit dea0e9f into jenkinsci:master Nov 30, 2025
10 checks passed
@lemeurherve lemeurherve deleted the reorder-and-polish-windows-tests branch December 1, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants