-
Notifications
You must be signed in to change notification settings - Fork 57
Require Jenkins 2.479.3 or newer and Jakarta EE 9 #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Markus Winter <m.winter@sap.com>
mawinter69
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pom looks good
mawinter69
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from pom point of view. The hpi is 2.4MiB and no longer over 12 MiB
Can't judge the other changes
|
@jenkinsci/datadog-plugin-developers Kindly requesting a review. |
|
Hey @strangelookingnerd, thanks for the contribution, but for now, we still want to be compatible with |
Require Jenkins 2.479.3 or newer and Jakarta EE 9
Jenkins 2.479.3 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.
Testing done
mvn clean verify- I had local test failures that I also had without my changes. So not entirely sure if these changes broke something or not. I'd advice that these changes are validated before merging.Submitter checklist