Html escaping for URIs and paths in the filesystem#16
Open
BenchmarkingBanana wants to merge 1 commit intojenkinsci:masterfrom
Open
Html escaping for URIs and paths in the filesystem#16BenchmarkingBanana wants to merge 1 commit intojenkinsci:masterfrom
BenchmarkingBanana wants to merge 1 commit intojenkinsci:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I added html escaping for the urls and the paths in the filesystem where the embedded items are stored. This makes it possible to name the cucumber tests with non ASCII characters. On some linux systems using non-ASCII characters created a problem when the plugin tries to convert the url into a filepath. Now the whole url and the filepaths are html escape and there is no problem in naming the tests whatever you want.