Resolving the 404 Error, that shows up every second time you open an embedded image#14
Open
BenchmarkingBanana wants to merge 1 commit intojenkinsci:masterfrom
Open
Conversation
will always send the embedded image to the browser and no 404 will be created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
first let me thank you for this plugin, it really helps me and fellow developers using cucumber tests.
But I ran into an issue using it. Every second time, I opened an embedded image, I got a 404. If I refreshed the page, I saw the image, refreshed again and it was gone again and I got another 404.
I tracked this done to some kind of problem concernig the serveFile-Method. If I exchange the file.lastModified attribute for 0, it works. So I think, the bug is that a 304 is somehow converted into a 404. A 304 is usually to tell the browser to load the image from cache because it has not changed. Anyway, I do not think, it makes a huge difference in performance to send the image to the browser everytime, that is why I am creating this pull request.