Migrate Commons Lang from 2 to 3 and StringEscapeUtils to Commons Text#118
Open
gounthar wants to merge 1 commit intojenkinsci:masterfrom
Open
Conversation
jglick
reviewed
Sep 9, 2025
|
|
||
| import net.sf.json.JSONObject; | ||
| import org.apache.commons.lang.StringUtils; | ||
| import org.apache.commons.lang3.StringUtils; |
Member
There was a problem hiding this comment.
better replaced with
Objects.equals
jglick
reviewed
Sep 9, 2025
| import jenkins.model.Jenkins; | ||
| import net.sf.json.JSONObject; | ||
| import org.apache.commons.lang.StringUtils; | ||
| import org.apache.commons.lang3.StringUtils; |
Member
There was a problem hiding this comment.
etc. better replaced with simple Java Platform equivalents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
command-launcherdevelopers! 👋This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:
Migrate Commons Lang from 2 to 3 and StringEscapeUtils to Commons Text
io.jenkins.tools.pluginmodernizer.MigrateCommonsLang2ToLang3AndCommonText
This pull request upgrades
Apache Commons Lang 2toApache Commons Lang 3and migrates HTML escaping functionality fromApache Commons LangtoApache Commons Text.The
Apache Commonscommunity recommends usingApache Commons Textfor string escaping operations, as it offers a more focused and feature-rich API for text processing.What's Changed?
Apache Commons Lang 2toCommons Lang 3.StringEscapeUtilsinApache Commons LangtoCommons Text.