Fix a NullPointerException when no groupId is provided#86
Closed
hatxet wants to merge 1 commit intojenkinsci:masterfrom
Closed
Fix a NullPointerException when no groupId is provided#86hatxet wants to merge 1 commit intojenkinsci:masterfrom
hatxet wants to merge 1 commit intojenkinsci:masterfrom
Conversation
The documentation explicitly says that the `teamPath` parameter overrides the `groupId` and it even recommends removing the `groupId` parameter if the `teamPath` is set. This fix prevents the CxCommonClient from throwing a NullPointerException when the `groupId` is null if the `teamPath` parameter has some value.
scurvydoggo
reviewed
Jan 3, 2022
| } | ||
| teamPath = getTeamNameFromId(cxConnectionDetails, descriptor, groupId); | ||
| if (teamPath == null) { | ||
| teamPath = getTeamNameFromId(cxConnectionDetails, descriptor, groupId); |
Member
There was a problem hiding this comment.
Will this actually fix the issue?
The title of the PR says "when no groupId is provided", however here it is testing teamPath for null, and continuing to use groupId as a parameter.
Member
There was a problem hiding this comment.
Nevermind, it looks good to me, based on your description
This fix prevents the CxCommonClient from throwing a NullPointerException when the
groupIdis null if theteamPathparameter has some value.
So the idea is to skip this step if the teamPath is already set with something.
scurvydoggo
approved these changes
Jan 3, 2022
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation explicitly says that the
teamPathparameteroverrides the
groupIdand it even recommends removing thegroupIdparameter if the
teamPathis set.This fix prevents the CxCommonClient from throwing a NullPointerException
when the
groupIdis null if theteamPathparameter has some value.