Report with results of both SCA and SAST from Jenkins Plugin#117
Open
swatiawate1 wants to merge 3 commits intomarch23-integrationfrom
Open
Report with results of both SCA and SAST from Jenkins Plugin#117swatiawate1 wants to merge 3 commits intomarch23-integrationfrom
swatiawate1 wants to merge 3 commits intomarch23-integrationfrom
Conversation
swatiawate1
requested review from
PravinGadankush,
SubhadraSahoo and
cx-umesh-waghode
|
|
||
|
|
||
| private void createScaReports(AstScaResults scaResults, File checkmarxBuildDir) { | ||
| private void createScaReports(AstScaResults scaResults, File checkmarxBuildDir, @Nonnull FilePath workspace) { |
Contributor
There was a problem hiding this comment.
i dont see use of new argument workspace in this method. Kindly check if it is required.
| } | ||
| ret.setEnablePolicyViolations(enableProjectPolicyEnforcement); | ||
|
|
||
| if (!ret.isAstScaEnabled() && !ret.getSynchronous()) { |
Contributor
There was a problem hiding this comment.
Please check if the condition should be && or ||
| createOsaReports(osaResults, checkmarxBuildDir); | ||
| } else if (scaResults != null && scaResults.isScaResultReady()) { | ||
| createScaReports(scaResults, checkmarxBuildDir); | ||
| createScaReports(scaResults, checkmarxBuildDir, workspace); |
Contributor
There was a problem hiding this comment.
Check if additional argument workspace is needed in this method.
Contributor
PravinGadankush
left a comment
PravinGadankush
left a comment
There was a problem hiding this comment.
Please work on the review comments.
PravinGadankush
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.