adding stop functionality for graceful shutdown#59
Open
odedva wants to merge 3 commits intojegesh:masterfrom
Open
adding stop functionality for graceful shutdown#59odedva wants to merge 3 commits intojegesh:masterfrom
odedva wants to merge 3 commits intojegesh:masterfrom
Conversation
Author
|
hey - @jegesh would you be able to take a look on this ? |
Owner
|
Hi! Thanks for the contribution. I'm just not clear on the use case you're addressing in this PR. Please explain |
Author
|
hey - if this is running in a thread, it would be nice to be able to gracefully shutdown the consumption of messages so the application that manages this thread with listener can ext nicely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_should_listenfor managing the state of the endless for loopstopfunction to stop listening and making thelistenfunction to return