Pull jquery resources locally instead of from the internet#747
Pull jquery resources locally instead of from the internet#747arvinsingla wants to merge 1 commit intomasterfrom
Conversation
jegelstaff
left a comment
There was a problem hiding this comment.
Looks good to me. On the other hand, in production systems, like a high traffic formulize.net, we would want to pull from some kind of high volume provider like Google, not dish out all that ourselves? But I don't think that's any reason not to do this change now.
|
Actually.... I think I want to take a different approach here and use environment variables to dictate behaviour. Default will be to pull from the remote cdn. But if $ENVIRONMENT=local We'll use the included version. |
|
So does this mean there's more work to do here? Or does the Environment variable thing mean it's just something you can do locally when you need to, and no change to the code? I'm thinking you need some change to the code in order to respect an env variable if present? |
|
There's a little bit of work left to do here to have it swap out the values if the environment varible is present. |
8a6f324 to
973aaeb
Compare
da2795e to
b0743e8
Compare
03c0c5f to
d51586f
Compare
336216a to
e871618
Compare
I was unable to run the e2e tests on the train when the internet was down because the jQuery resources were trying to load from the internet. Since the browser is fully reset between every test there's no caching of these resources.