Skip to content

Pull jquery resources locally instead of from the internet#747

Open
arvinsingla wants to merge 1 commit intomasterfrom
ISSUE/local-jquery-resources
Open

Pull jquery resources locally instead of from the internet#747
arvinsingla wants to merge 1 commit intomasterfrom
ISSUE/local-jquery-resources

Conversation

@arvinsingla
Copy link
Copy Markdown
Collaborator

I was unable to run the e2e tests on the train when the internet was down because the jQuery resources were trying to load from the internet. Since the browser is fully reset between every test there's no caching of these resources.

Copy link
Copy Markdown
Owner

@jegelstaff jegelstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. On the other hand, in production systems, like a high traffic formulize.net, we would want to pull from some kind of high volume provider like Google, not dish out all that ourselves? But I don't think that's any reason not to do this change now.

@arvinsingla
Copy link
Copy Markdown
Collaborator Author

Actually.... I think I want to take a different approach here and use environment variables to dictate behaviour. Default will be to pull from the remote cdn. But if $ENVIRONMENT=local We'll use the included version.

@jegelstaff
Copy link
Copy Markdown
Owner

So does this mean there's more work to do here? Or does the Environment variable thing mean it's just something you can do locally when you need to, and no change to the code? I'm thinking you need some change to the code in order to respect an env variable if present?

@arvinsingla
Copy link
Copy Markdown
Collaborator Author

There's a little bit of work left to do here to have it swap out the values if the environment varible is present.

@jegelstaff jegelstaff force-pushed the master branch 10 times, most recently from 8a6f324 to 973aaeb Compare December 3, 2025 21:14
@jegelstaff jegelstaff force-pushed the master branch 10 times, most recently from da2795e to b0743e8 Compare December 12, 2025 18:21
@jegelstaff jegelstaff force-pushed the master branch 3 times, most recently from 03c0c5f to d51586f Compare January 16, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants