Open
Conversation
Owner
Author
|
jegelstaff
force-pushed
the
master
branch
4 times, most recently
from
c2fb601 to
033b270
Compare
jegelstaff
force-pushed
the
master
branch
10 times, most recently
from
8a6f324 to
973aaeb
Compare
jegelstaff
force-pushed
the
master
branch
10 times, most recently
from
da2795e to
b0743e8
Compare
jegelstaff
force-pushed
the
master
branch
2 times, most recently
from
e8d0997 to
0102763
Compare
jegelstaff
force-pushed
the
master
branch
4 times, most recently
from
336216a to
e871618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carefully limit deletion to only entries the user could normally delete. Also allow them to limit the deletion, in case they are uploading only a subset of entries, and just want to delete others not present in the sheet only if they are part of the subset. ie: uploading June block students, so delete students not in sheet, but only if they're June block in the DB, because the upload is taken as authoritative.