fix(visionOS): position initial blocks at eye level instead of below eye level#4
Merged
jeffmarcilliat merged 1 commit intomasterfrom Aug 23, 2025
Conversation
… below eye level - Changed baseY from -0.1 to 1.6 in createBlockEntity function - Aligns with existing eye level reference used in ray casting (line 876) - Blocks now appear at natural eye level when app launches - Maintains relative spacing between blocks (0.03 increment per block) Co-Authored-By: Jeffrey <jeffmarcilliat@mac.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(visionOS): position initial blocks at eye level instead of below eye level
Summary
Fixed an issue where blockchain blocks were positioned too low when the VisionOS app launches. The blocks were initially positioned at Y = -0.1 meters (below eye level), causing users to have to look down to see them. This change repositions the blocks to start at Y = 1.6 meters, which aligns with the eye level reference already established in the app's ray casting functionality.
Key Change:
baseYcalculation increateBlockEntity()function from-0.1to1.6Review & Testing Checklist for Human
Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD BCHIV["visionOS/MempoolVisionOS/Views/<br/>BlockchainImmersiveView.swift"]:::major-edit CBE["createBlockEntity()<br/>function"]:::major-edit RC["performRayCastingForGaze()<br/>function"]:::context LT["Loading Text<br/>(Y = 1.0)"]:::context BCHIV --> CBE BCHIV --> RC BCHIV --> LT CBE --> |"baseY: -0.1 → 1.6"| POS["Block Position<br/>(Eye Level)"]:::major-edit RC --> |"rayOrigin Y = 1.6<br/>(reference)"| EYE["Eye Level Reference"]:::context subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes