Skip to content

Conversation

@augustobottelli
Copy link

@augustobottelli augustobottelli commented Oct 23, 2021

Hey Jeff!

Just used your scrapper for a personal project and I added a few features + formatting which I wanted to share with you just in case you find them useful!

  • Handle paths from __file __ to avoid hardcoding them (works for MacOS/Windows)
  • Added concurrent requests to API
  • Format with Black

Pd: Thank you very much for your contributions!

Pd2: I should've separated all of those changes in separate PRs but I didn't have much time to do so. If you need me to, just let me know! (especially removing the formatting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant