Fix Android CI build and release #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove FIXME comment and activate build-android job - Enable JDK 17 setup, Android SDK, and Gradle configuration - Restore demo-app build and unit test execution steps - Prepare for fixing Android build issues in subsequent commits Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s496be885aa3c9back
- Bump gradle-version from 8.11 to 8.13 in CI workflow - Fix compatibility with Android Gradle Plugin 8.11.0 minimum requirements - Resolve build failure: 'Minimum supported Gradle version is 8.13' Co-Authored-By: sketch <hello@sketch.dev> Change-ID: sb53c1c16819156cfk
- Create mock Firebase configuration file for demo-app - Enable Android build to proceed without real Firebase project - Update .gitignore to allow dummy google-services.json for CI purposes - Contains minimal valid structure matching package name org.nella.fcmapp - Resolves build error: 'File google-services.json is missing' Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s3d9457fcdf10fd52k
- Add step to create google-services.json from GOOGLE_SERVICES_JSON secret - Remove dummy google-services.json file from repository - Restore proper .gitignore exclusion for google-services.json - Enable secure Firebase configuration management through GitHub secrets - CI will now dynamically create the file during build process Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s2a78e59786d788bbk
- Rename GitHub secret from GOOGLE_SERVICES_JSON to FIREBASE_CLIENT_CONFIG - Update step name to 'Create Firebase client config from secret' - Emphasize this is client configuration for FCM, not service account credentials - Resolve naming confusion between client config and server service accounts Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s1bc580182499b1e4k
- Replace java.util.Base64 with android.util.Base64 for broader compatibility - Change Base64.getEncoder().encodeToString() to Base64.encodeToString(data, Base64.DEFAULT) - Change Base64.getDecoder().decode() to Base64.decode(data, Base64.DEFAULT) - Maintain support for Android API 21+ without requiring API level 26 - Resolve NewApi lint error for Base64 encoder/decoder methods Co-Authored-By: sketch <hello@sketch.dev> Change-ID: sbb7337cd4fee1bc4k
- Bump Gradle version from 8.4 to 8.13 to match Android Gradle Plugin requirements - Add Firebase client config step using FIREBASE_CLIENT_CONFIG secret - Create google-services.json dynamically before APK build process - Apply same fixes from ci.yml to ensure consistent release builds - Enable successful APK generation with proper Firebase configuration Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s17e5e5d6f9582c23k
- Comment out Go binary build jobs (build-go-binaries and upload-go-binaries) - Update actions/upload-artifact from deprecated v3 to v4 - Focus release workflow on Android APK generation only - Resolve GitHub Actions deprecation warning for artifact actions - Streamline release process for faster execution Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s28fdfbe538db6118k
- Change APK name from minnotif-android to remote-notify-demo-app - Add contents: write permission to build-apk job for release creation - Update release body text to reflect new APK naming - Resolve 'Resource not accessible by integration' error for GitHub releases - Enable proper release artifact upload with correct permissions Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s08a634767a4c767ak
jeffallen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-ID: s496be885aa3c9back