Conversation
- 라이트 팔레트 채도 조정으로 따뜻한 톤 유지 - cardBackground 커스텀 토큰 추가 (light: white, dark: rgba) - 헤더 border 제거 및 배경색 상속 처리 - ScreenLayout에 $background 적용 - React Navigation contentStyle로 배경색 오버라이드 해결 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- 카드 컴포넌트 shadow 제거, cardBackground + subtle border 적용 - 버튼 disabled 스타일 통일 ($color3 배경 + opacity) - Input/TextArea 배경색 $cardBackground로 통일, border 제거 - 폰트 weight/color 계층 정리 (700→600→400, color11→color9→color7) - accent 컬러 일관성 있게 적용 (버튼, 승인 대기 상태) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Group 타입에 memberCount, lastDiaryAt 필드 추가 - 그룹 카드 Footer에 아이콘+멤버 수, 최근 일기 시간 표시 - 헤더의 일기 작성 버튼을 우측 하단 FAB로 분리 - 헤더에서 초대 코드 버튼만 유지 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- deleteDiary API 함수 추가 (DELETE /api/groups/{groupId}/diaries/{diaryId})
- useDeleteDiaryMutation 훅 생성
- 일기 상세 헤더에 삭제 버튼 추가 (확인 Alert → 삭제 → toast 알림)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- react-native-quick-crypto 빌드 에러 해결을 위해 nitro-modules 0.33.2로 업데이트 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
카드용 상대시간과 섹션 헤더용 날짜 라벨을 별도 함수로 분리하고, 7일 초과 시 정확한 날짜를 표시하도록 개선 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
모든 바텀시트에 일관된 3단 구조 적용: - 제목 헤더 추가 (GroupRequestSheet, GroupActionSheet) - 닫기 버튼을 chromeless 스타일로 통일 - GroupActionSheet를 카드형 메뉴로 재디자인 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant overhaul of the application's user interface and experience, particularly within the group and diary management features. It introduces more informative group displays, empowers users with diary deletion capabilities, and refines the overall visual theme for a more polished and intuitive interaction. These changes aim to enhance clarity and functionality across key user flows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant UI refresh across the application, aligning components with a new, more consistent design system and color palette. It also adds group information to the group list, such as member count and last activity, and implements a feature to delete diaries. The code is generally well-structured, but there are a few areas for improvement. I've identified a critical issue in DiaryDetailScreen that could lead to a crash due to unsafe access of data that might be undefined during loading. I've also suggested a refactoring for better readability and pointed out a potential maintenance issue with a modified dependency file.
| <CommonHeader /> | ||
| <CommonHeader | ||
| right={ | ||
| diary.mine ? ( |
There was a problem hiding this comment.
The diary object can be undefined while data is loading, as useDiaryDetailQuery doesn't appear to be a suspense query. Accessing diary.mine here will cause a crash. The entire component body that relies on diary should be conditionally rendered only after diary is available. This also applies to DiaryContent on line 92.
| const PACKAGE_VERSION = '2.12.4' | ||
| const INTEGRITY_CHECKSUM = '4db4a41e972cec1b64cc569c66952d82' | ||
| const IS_MOCKED_RESPONSE = Symbol('isMockedResponse') | ||
| const activeClientIds = new Set() | ||
|
|
||
| addEventListener("install", function () { | ||
| self.skipWaiting(); | ||
| }); | ||
| addEventListener('install', function () { | ||
| self.skipWaiting() | ||
| }) |
There was a problem hiding this comment.
The comment at the top of this file states Please do NOT modify this file.. The changes in this file appear to be stylistic formatting (e.g., changing double quotes to single quotes, removing semicolons), likely applied by a code formatter. Modifying this auto-generated file from the msw dependency can lead to maintenance issues and merge conflicts when updating the package. It's recommended to exclude this file from your formatting and linting tools.
| onPress={() => | ||
| Alert.alert("일기 삭제", "정말 이 일기를 삭제하시겠습니까?", [ | ||
| { text: "취소", style: "cancel" }, | ||
| { | ||
| text: "삭제", | ||
| style: "destructive", | ||
| onPress: () => | ||
| deleteMutation.mutate( | ||
| { groupId, diaryId }, | ||
| { | ||
| onSuccess: () => { | ||
| toast.show("일기가 삭제되었습니다.", { | ||
| native: true, | ||
| }); | ||
| navigation.goBack(); | ||
| }, | ||
| onError: () => { | ||
| toast.show("일기 삭제에 실패했습니다.", { | ||
| native: true, | ||
| }); | ||
| }, | ||
| }, | ||
| ), | ||
| }, | ||
| ]) | ||
| } |
There was a problem hiding this comment.
This inline onPress handler is quite complex. To improve readability and maintainability, consider extracting this logic into a separate named function within the component.
For example, you could define a handleDeleteDiary function and call it from onPress:
const handleDeleteDiary = () => {
Alert.alert("일기 삭제", "정말 이 일기를 삭제하시겠습니까?", [
{ text: "취소", style: "cancel" },
{
text: "삭제",
style: "destructive",
onPress: () => {
deleteMutation.mutate(
{ groupId, diaryId },
{
onSuccess: () => {
toast.show("일기가 삭제되었습니다.", { native: true });
navigation.goBack();
},
onError: () => {
toast.show("일기 삭제에 실패했습니다.", { native: true });
},
}
);
},
},
]);
};Then use onPress={handleDeleteDiary} in your Button.
1 participant
No description provided.