Add additional test coverage#1
Merged
jecsand838 merged 1 commit intojecsand838:avro-row-encoderfrom Jan 24, 2026
Merged
Conversation
jecsand838
merged commit 9891885
into
jecsand838:avro-row-encoder
22 of 23 checks passed
Owner
|
@alamb These look great! I can clean them up on my end. Thank you so much for helping with this 😄 |
jecsand838
added a commit
that referenced
this pull request
Jan 24, 2026
Add additional test coverage
jecsand838
pushed a commit
that referenced
this pull request
Feb 13, 2026
# Which issue does this PR close? small optimization # Rationale for this change key insight is the byte clone is cheap just a ref count compare to vec clone is a alloc + memcopy. before ``` let mut result = Vec::new(); // alloc #1 result.extend_from_slice(prefix); result.extend_from_slice(suffix); let data = Bytes::from(result.clone()); // alloc apache#2 + memcpy item.set_from_bytes(data); self.previous_value = result; // keep Vec ``` after ``` let mut result = Vec::with_capacity(prefix_len + suffix.len()); // alloc #1 result.extend_from_slice(&self.previous_value[..prefix_len]); result.extend_from_slice(suffix); let data = Bytes::from(result); // no alloc, takes Vec buffer item.set_from_bytes(data.clone()); // cheap refcount bump self.previous_value = data; // move, no alloc ``` # What changes are included in this PR? previous_value type changed to Bytes preallocate result vec capacity. # Are these changes tested? the existing test should pass # Are there any user-facing changes? no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing apache#9171 from @jecsand838 I used code coverage
cargo llvm-covand found some uncovered code.I wrote some additional tests with codex for your consideration