Added implementation for function application check #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jlvargasme
commented
Oct 23, 2023
jlvargasme
commented
- Function application is implemented for functions that do not have tuples as arguments
- Fixed parsing to accept refinement functions with refinement tuples
- Implementing refinement function declaration that has refinement tuples as arguments
- Implement refinement function application check for function with refinement tuples as arguments
- Fixed function input satisfiability check
…ecl.mk_apply with user arguments
jchen-cs
requested changes
Oct 23, 2023
Collaborator
jchen-cs
left a comment
jchen-cs
left a comment
There was a problem hiding this comment.
Reviewed code together, spotted an issue on line 1060 in z3refinement.ml. Everything else looks good and will approve once that is fixed.
| let node main () = | ||
| let z = add (1.,2.) in | ||
| () | ||
|
|
Collaborator
There was a problem hiding this comment.
Remove empty lines at end of file
Collaborator
Author
There was a problem hiding this comment.
removed empty lines
| let check_env = { exp_env = ref (checks @ !(local_env.exp_env)); var_env = Hashtbl.create 0} in | ||
| check_validity ctx constraint_env check_env; | ||
| let check_env = checks @ !(local_env.exp_env) @ !(ref_fun.creation_env.exp_env) in | ||
| check_validity ctx checks; |
Collaborator
There was a problem hiding this comment.
We noticed a bug here during our code review. check_validity returns true even if constraints are not satisfied due to the use of an implication statement. Quick fix is to replace the original implication x -> x with T -> x (just true in the antecedent) to keep with the original function interface with minimal changes.
Collaborator
Author
There was a problem hiding this comment.
Fixed with the latest commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.