fix: add developer agent tests, fix calculator security, improve registry, add CLI info command#6
Merged
Conversation
…stry, add CLI info command - Add comprehensive test file for DeveloperAgent with 5 tests covering system prompt, local tools, tool descriptions, run method, and MCP tool integration- Replace dangerous eval() in CalculatorTool with safe AST-based math evaluator supporting basic operators (+, -, *, /, //, %, **) and functions (abs, round, min, max, sum). Blocks dangerous operations like __import__ and attribute access- Add duplicate registration validation to AgentRegistry with DuplicateAgentRegistrationError exception, set_strict_registration() method, and optional override parameter for controlled overwrites- Add CLI 'info' command to display agent details including class name, module, MCP servers, system prompt, and available tools- Fix ruff issues: long lines in example.py and test_developer_agent.py, unused variable in test- Fix mypy issues: return type annotations in registry.py and cli.py, Callable import, typing fixes in example.py- Update AGENTS.md with new registry methods and CLI command documentation- Update TODO.md marking 4 items complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system prompt, local tools, tool descriptions, run method, and MCP
tool integration- Replace dangerous eval() in CalculatorTool with safe
AST-based math evaluator supporting basic operators (+, -, *, /, //,
%, **) and functions (abs, round, min, max, sum). Blocks dangerous
operations like import and attribute access- Add duplicate
registration validation to AgentRegistry with
DuplicateAgentRegistrationError exception, set_strict_registration()
method, and optional override parameter for controlled overwrites-
Add CLI 'info' command to display agent details including class name,
module, MCP servers, system prompt, and available tools- Fix ruff
issues: long lines in example.py and test_developer_agent.py, unused
variable in test- Fix mypy issues: return type annotations in
registry.py and cli.py, Callable import, typing fixes in example.py-
Update AGENTS.md with new registry methods and CLI command
documentation- Update TODO.md marking 4 items complete