Shorten and simplify #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Some of the changes I have made to this file involve the implementation of the walrus operator --> := If you do not intend on running this code in python versions 3.8 or above, you can remove the walrus operator changes that I have suggested and just go ahead with the rest of the changes. This will do the same thing that your code already does, just in a shorter and more easy-to-understand fashion.
Author
|
It appears that this is a bot you are using to check the code. Did the changes fail because it wasn't run in python 3.8 or above (for compatibility with the walrus operator)? |
Owner
|
Yes, it checks the compatibility for python 2.7. |
Author
|
Do you guys plan on using it in python 2.7? |
Owner
|
Some of the machines are still using python2. The default python of my cloud VM is also python2. So I think we'd better make the lib compatible with python2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Some of the changes I have made to this file involve the implementation of the walrus operator --> := If you do not intend on running this code in python versions 3.8 or above, you can remove the walrus operator changes that I have suggested and just go ahead with the rest of the changes.
This will do the same thing that your code already does, just in a shorter and more easy-to-understand fashion.