Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result
in the rejection of the pull request.
Please provide enough information so that others can review your pull request. You
can skip this if you're fixing a typo or adding an app to the Showcase.
Explain the details for making this change. What existing problem does the pull
request solve?
Ex:
If you "Added a/changed the function to do X", explain why:
If you "Fixed bug/error in X", explain:
Code style and formatting
Check the Contributors Style Guidelines section
for how to write your code and the Contributors Code Formatting section
for how to format your code.
Closing Issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes(if such).
Fixes #XXXX
Proposed changes
Motivation behind changes
Test plan
Demonstrate the code is solid. Example: The exact commands you ran and their output,
screenshots / videos if the pull request changes UI.
Make sure tests pass on all of the relevant CI workflows.
Pull Request Readiness Checklist
See details at CONTRIBUTING.md.
I agree to contribute to the project under [INSERT PROJECT NAME] (Unlicense)
License.
To the best of my knowledge, the proposed patch is not based on a code under
GPL or other license that is incompatible with [INSERT PROJECT NAME]
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in the repository,
if applicable
The feature is well documented and sample code can be built with the project
CMake