fix: remove redundant _capnp declaration in Struct#170
Open
mrbbot wants to merge 1 commit intojdiaz5513:masterfrom
Open
fix: remove redundant _capnp declaration in Struct#170mrbbot wants to merge 1 commit intojdiaz5513:masterfrom
_capnp declaration in Struct#170mrbbot wants to merge 1 commit intojdiaz5513:masterfrom
Conversation
|
Thanks for this PR, this is the only way to actually get deserialization to work at all. Without this, the published 0.7.0 gives the runtime error That points to the second line in this javascript constructor: constructor(segment, byteOffset, depthLimit = MAX_DEPTH, compositeIndex) {
super(segment, byteOffset, depthLimit);
this._capnp.compositeIndex = compositeIndex;
this._capnp.compositeList = compositeIndex !== void 0;
}If I use the this PRs capnp-ts in package.json: the problem goes away. 0.7.0 used to work fine, so I suspect this is a problem with a new version of Typescript or node or Vite? Would be great to get this merged to that capnp-ts in npmjs would actually be usable! |
antiphoton
added a commit
to antiphoton/capnp-ts
that referenced
this pull request
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! 👋 Thanks for building this package! Super useful! 🙂 I hit this error when trying to type check a project:
Removing the redundant declaration seems to fix this. 👍