Skip to content

Conversation

@G-eos
Copy link

@G-eos G-eos commented Mar 8, 2020

Please consider adding this modification.

Move parameter outside of scripts for easier confidenciality.
Add network name in email title to differenciate VPNs
Add information at latest disconnection to see duration and volume of data
Add search for bad login and notify.

G-eos added 10 commits March 8, 2020 13:48
    Move parameter outside of scripts for easier confidenciality.
    Add network name in email title to differenciate VPNs
    Add information at latest disconnection to see duration and volume of data
try shellcheck
Add shellcheck
Move SSMTP config into cron ran file through cheking that SSMTP files are available.
@G-eos G-eos force-pushed the master branch 2 times, most recently from a4025dd to f4f6af3 Compare March 22, 2020 17:38
It does not work well enough
@G-eos
Copy link
Author

G-eos commented Mar 23, 2020

@jcoutch please review or at least tell that you will not merge :) so i stop to push new commit on this PR and do a fork :)

@jcoutch
Copy link
Owner

jcoutch commented Mar 23, 2020

With everything going on right now, I haven't had any free time to review changes to any of my open source projects. I'll get to it eventually. 🙂

@G-eos
Copy link
Author

G-eos commented Mar 23, 2020

Thanks :) for sure ! No urgent for me, just to know :)
In my plan I just need to add

  • filter better bad login to avoid logrotare change of line lead to false positive
  • document the CloudKey conf for the cron config every minute. As wen this is provisionned again the files remain but the conf of periodic task is lost :)

So I will do it and push them later, when I will have some time too !

@G-eos
Copy link
Author

G-eos commented Apr 4, 2020

Just remain to document the cron conf from cloudkey to be persistent to provisioning. :)

@G-eos
Copy link
Author

G-eos commented Apr 4, 2020

Finished for me. Please can you merge.

@pcw132
Copy link

pcw132 commented May 16, 2020

@G-eos @jcoutch

Has this been approved to merge or a fork created?
the changes sound positive. i'm new to github so i an unsure how this works. I came here because have a need for this script on my USG. If this has been forked, can you send me the project link?

@G-eos
Copy link
Author

G-eos commented May 16, 2020

Hello, not merged so far. It works for me since more than one month without trouble. You can find the fork here: https://github.com/G-eos/usg-scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants