add get_tracking_numbers method #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! I was thinking of doing something similar 😃 what do you think about searching not just a string of numbers but any text? Kind of like what the main ruby gem does with TrackingNumber.search |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thank you for creating this package! I've been looking for a python-implementation of
jkeensspec for a while.Currently,
get_tracking_numberreturns the first validTrackingNumberbased on a givennumber. However, I'd like to be able to get all matchingTrackingNumbers (with differing couriers) and add some logic to select the most appropriate courier afterwards. I've added a new functionget_tracking_numbers(number: str) -> list[TrackingNumber]which does exactly this. Let me know what you think!