Skip to content

Potential Vulnerability in Cloned Code #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pr-hung wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Potential Vulnerability in Cloned Code #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions drivers/net/netdevsim/fib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ struct nsim_fib_data {
struct devlink *devlink;
struct work_struct fib_event_work;
struct work_struct fib_flush_work;
struct work_struct fib_flush_work;
struct list_head fib_event_queue;
spinlock_t fib_event_queue_lock; /* Protects fib event queue list */
struct mutex nh_lock; /* Protects NH HT */
Expand Down Expand Up @@ -1499,23 +1500,41 @@ static void nsim_fib_event_work(struct work_struct *work)
}

static void nsim_fib_flush_work(struct work_struct *work)
static void nsim_fib_flush_work(struct work_struct *work)
{
{
struct nsim_fib_data *data = container_of(work, struct nsim_fib_data,
struct nsim_fib_data *data = container_of(work, struct nsim_fib_data,
fib_flush_work);
fib_flush_work);
struct nsim_fib_rt *fib_rt, *fib_rt_tmp;
struct nsim_fib_rt *fib_rt, *fib_rt_tmp;


/* Process pending work. */
/* Process pending work. */
flush_work(&data->fib_event_work);
flush_work(&data->fib_event_work);


mutex_lock(&data->fib_lock);
mutex_lock(&data->fib_lock);
list_for_each_entry_safe(fib_rt, fib_rt_tmp, &data->fib_rt_list, list) {
list_for_each_entry_safe(fib_rt, fib_rt_tmp, &data->fib_rt_list, list) {
rhashtable_remove_fast(&data->fib_rt_ht, &fib_rt->ht_node,
rhashtable_remove_fast(&data->fib_rt_ht, &fib_rt->ht_node,
nsim_fib_rt_ht_params);
nsim_fib_rt_ht_params);
nsim_fib_rt_free(fib_rt, data);
nsim_fib_rt_free(fib_rt, data);
}
}
mutex_unlock(&data->fib_lock);
mutex_unlock(&data->fib_lock);
}
}


static int
nsim_fib_debugfs_init(struct nsim_fib_data *data, struct nsim_dev *nsim_dev)
{
Expand Down Expand Up @@ -1625,6 +1644,7 @@ struct nsim_fib_data *nsim_fib_create(struct devlink *devlink,
err_nexthop_nb_unregister:
unregister_nexthop_notifier(devlink_net(devlink), &data->nexthop_nb);
err_rhashtable_fib_destroy:
cancel_work_sync(&data->fib_flush_work);
cancel_work_sync(&data->fib_flush_work);
flush_work(&data->fib_event_work);
rhashtable_free_and_destroy(&data->fib_rt_ht, nsim_fib_rt_free,
Expand Down Expand Up @@ -1656,6 +1676,7 @@ void nsim_fib_destroy(struct devlink *devlink, struct nsim_fib_data *data)
unregister_fib_notifier(devlink_net(devlink), &data->fib_nb);
unregister_nexthop_notifier(devlink_net(devlink), &data->nexthop_nb);
cancel_work_sync(&data->fib_flush_work);
cancel_work_sync(&data->fib_flush_work);
flush_work(&data->fib_event_work);
rhashtable_free_and_destroy(&data->fib_rt_ht, nsim_fib_rt_free,
data);
Expand Down