feature: make encType/addr/realm/domain configrable#1
Open
zhuliquan wants to merge 4 commits intojcmturner:masterfrom
Open
feature: make encType/addr/realm/domain configrable#1zhuliquan wants to merge 4 commits intojcmturner:masterfrom
zhuliquan wants to merge 4 commits intojcmturner:masterfrom
Conversation
|
Good feature! In my case I wanted to create multiple test KDCs with different Realms. I think that instead of storing this in globals we should add some kind of options structure (or just more argumenst) to NewKDC function. IMHO globals are not flexible enough. What you think? |
Author
I also agree with you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this mocktest in our project tests, but I found that there were a lot of global variables that I couldn't customize, which made me unable to use them well. So I changed some variables (such as ServerAddr) to be modifiable outside the package