Skip to content

feature: make encType/addr/realm/domain configrable#1

Open
zhuliquan wants to merge 4 commits intojcmturner:masterfrom
zhuliquan:master
Open

feature: make encType/addr/realm/domain configrable#1
zhuliquan wants to merge 4 commits intojcmturner:masterfrom
zhuliquan:master

Conversation

@zhuliquan
Copy link

I wanted to use this mocktest in our project tests, but I found that there were a lot of global variables that I couldn't customize, which made me unable to use them well. So I changed some variables (such as ServerAddr) to be modifiable outside the package

@mikegolod
Copy link

Good feature! In my case I wanted to create multiple test KDCs with different Realms. I think that instead of storing this in globals we should add some kind of options structure (or just more argumenst) to NewKDC function. IMHO globals are not flexible enough. What you think?

@zhuliquan
Copy link
Author

Good feature! In my case I wanted to create multiple test KDCs with different Realms. I think that instead of storing this in globals we should add some kind of options structure (or just more argumenst) to NewKDC function. IMHO globals are not flexible enough. What you think?

I also agree with you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants