Fix devcontainer stuff#5
Merged
jclerman merged 5 commits intojclerman:switch-to-poetryfrom Jan 16, 2023
Merged
Conversation
This reverts commit a4da002.
…o install poetry with all extras flag.
…mmands inside the devcontainer with docker volumes from the host
This should avoid interference between different containers and the host environment.
jclerman
approved these changes
Jan 16, 2023
Owner
jclerman
left a comment
jclerman
left a comment
There was a problem hiding this comment.
LGTM. Tested on my laptop and this solves the poetry environment-contamination issue I was encountering previously with use of the devcontainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the work done in #3 by @edmondchuc but I set specific directories for local state that ensures things created by the devcontainer does not contaminate the host environment.
For more info see: