Fix lint errors: errcheck, nilerr, and govet shadow#11
Merged
Conversation
* Objective Resolve all reported lint issues, including errcheck, nilerr, and govet shadow warnings. * Why Unchecked errors and shadowed variables can hide failures and lead to unreliable behavior in production and tests. * How Handle return values from errgroup.Wait() and semaphore.Acquire() instead of discarding them. Propagate errors returned by GetAllBranches during branch listing. Rename shadowed err variables in tests and ensure all error returns in test helpers are properly checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all reported lint issues, including errcheck, nilerr, and govet shadow warnings.
Unchecked errors and shadowed variables can hide failures and lead to unreliable behavior in production and tests.
Handle return values from errgroup.Wait() and
semaphore.Acquire() instead of discarding them.
Propagate errors returned by GetAllBranches during branch listing.
Rename shadowed err variables in tests and ensure all error returns in test helpers are properly checked.