Skip to content

Comments

Fix linting errors in @gridweaver/react#3

Merged
jchoi2x merged 2 commits intomainfrom
copilot/fix-linting-error
Nov 25, 2025
Merged

Fix linting errors in @gridweaver/react#3
jchoi2x merged 2 commits intomainfrom
copilot/fix-linting-error

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Two ESLint errors were failing the lint target for @gridweaver/react.

Changes

  • AgTable.spec.tsx: Added eslint-disable-next-line for intentional empty function in never-resolving Promise (tests loading state)
  • AgTable.tsx: Removed unused _event parameter from handleCellClicked and its CellClickedEvent import
// Before
private handleCellClicked = (_event: CellClickedEvent) => {
  // Cell click handler - can be extended via gridProps.onCellClicked
};

// After
private handleCellClicked = () => {
  // Cell click handler - can be extended via gridProps.onCellClicked
};
Original prompt

fix the linting error


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: jchoi2x <2028917+jchoi2x@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix linting error in the codebase Fix linting errors in @gridweaver/react Nov 25, 2025
Copilot AI requested a review from jchoi2x November 25, 2025 03:54
@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot whats going on with Projects must list all files or use an 'include' pattern. warnings when you build?

Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

@copilot whats going on with Projects must list all files or use an 'include' pattern. warnings when you build?

Those Projects must list all files or use an 'include' pattern warnings are pre-existing TypeScript declaration file generation issues unrelated to this PR. I verified by building with the original code before my changes - the same warnings appear. They occur during the vite:dts plugin's declaration file generation because libs/react/tsconfig.lib.json doesn't properly reference the @gridweaver/core source files. The build still succeeds; these are TypeScript configuration issues that would require a separate fix to the tsconfig setup.

@jchoi2x jchoi2x marked this pull request as ready for review November 25, 2025 04:26
@jchoi2x jchoi2x merged commit 69a1cfe into main Nov 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants