Skip to content

Comments

Reformat PRD.md and implement React AG-Grid component#2

Merged
jchoi2x merged 5 commits intomainfrom
copilot/reformat-prd-md
Nov 25, 2025
Merged

Reformat PRD.md and implement React AG-Grid component#2
jchoi2x merged 5 commits intomainfrom
copilot/reformat-prd-md

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

PRD.md had malformed markdown: missing header syntax, unfenced code blocks, and an artifact prefix line.

PRD.md Changes:

  • Removed erroneous [cite_start] artifact on line 1
  • Added proper header hierarchy (#, ##, ###, ####)
  • Fenced TypeScript code blocks with ```typescript
  • Normalized bullet points and added inline code formatting for identifiers

React AG-Grid Component Implementation:

Implemented @gridweaver/react library based on the Angular reference implementation from jchoi2x/templating:

  • Added core types in @gridweaver/core (SerializedColumnDef, TableHttpSpec, SerializedTableDefinition, TableDefinition)
  • Added Angular Expressions parser for valueFormatter serialization
  • Implemented AgTable React class component that:
    • Takes a url prop to fetch table definitions from the API
    • Uses modular AG Grid packages (@ag-grid-community/core, @ag-grid-community/react) as peer dependencies
    • Accepts a modules prop to pass AG Grid modules (e.g., ServerSideRowModelModule)
    • Supports custom cell renderers via onOptionClicked callback
    • Persists column state to localStorage
  • Added basic tests

Usage Example:

import { AgTable } from '@gridweaver/react';
import { ServerSideRowModelModule } from '@ag-grid-enterprise/server-side-row-model';

<AgTable 
  url="/api/table-definitions/users"
  modules={[ServerSideRowModelModule]}
  onRowSelectionChanged={(rows) => console.log(rows)}
/>
Original prompt

Reformat PRD.md and fix it up.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: jchoi2x <2028917+jchoi2x@users.noreply.github.com>
Copilot AI changed the title [WIP] Reformat PRD.md and improve clarity Reformat PRD.md with proper markdown structure Nov 24, 2025
Copilot AI requested a review from jchoi2x November 24, 2025 23:37
@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot Take a look at https://github.com/jchoi2x/templating/tree/bugfix/ssrm/libs/ag-table/src/lib start implementing a react version of it in the react lib in this repo.

@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot Take a look at https://github.com/jchoi2x/templating/tree/bugfix/ssrm/libs/ag-table/src/lib start implementing a react version of it in the react lib in this repo.

Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

@copilot Take a look at https://github.com/jchoi2x/templating/tree/bugfix/ssrm/libs/ag-table/src/lib start implementing a react version of it in the react lib in this repo.

I attempted to access https://github.com/jchoi2x/templating/tree/bugfix/ssrm/libs/ag-table/src/lib but the repository appears to be private or doesn't exist. Could you either make the repository accessible, or provide the relevant code files directly so I can implement the React version?

@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot Its a private repo. Can you access it if I allow it?

Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

@copilot Its a private repo. Can you access it if I allow it?

No, I cannot access private repositories even if you grant permission through GitHub's UI. My access is limited to publicly accessible content. To proceed, you could either:

  1. Make the repository temporarily public
  2. Copy the relevant files from libs/ag-table/src/lib directly into a comment or gist
  3. Push those files to a public location I can access

@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot I made it public try again

Co-authored-by: jchoi2x <2028917+jchoi2x@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

@copilot I made it public try again

Implemented the React version using modular AG Grid packages in commit 607e8e0.

The AgTable component:

  • Takes a url prop to fetch the table definition
  • Uses @ag-grid-community/core and @ag-grid-community/react as peer dependencies
  • Accepts a modules prop to register AG Grid modules (e.g., ServerSideRowModelModule)
  • Class component (no hooks as requested)

Usage example:

import { AgTable } from '@gridweaver/react';
import { ServerSideRowModelModule } from '@ag-grid-enterprise/server-side-row-model';

<AgTable 
  url="/api/table-definitions/users"
  modules={[ServerSideRowModelModule]}
/>

Co-authored-by: jchoi2x <2028917+jchoi2x@users.noreply.github.com>
Copilot AI changed the title Reformat PRD.md with proper markdown structure Reformat PRD.md and implement React AG-Grid component Nov 25, 2025
@jchoi2x
Copy link
Owner

jchoi2x commented Nov 25, 2025

@copilot All the tests pass?

Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

@copilot All the tests pass?

Yes, all tests pass:

  • @gridweaver/core: 1 test passed
  • @gridweaver/react: 2 tests passed (loading state and error state)

Co-authored-by: jchoi2x <2028917+jchoi2x@users.noreply.github.com>
@jchoi2x jchoi2x marked this pull request as ready for review November 25, 2025 02:44
@jchoi2x jchoi2x merged commit 9e5bf67 into main Nov 25, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants