Fix showing 2 notifications in certain scenarios#11
Open
stormageddon wants to merge 7 commits intojchen1:masterfrom
Open
Fix showing 2 notifications in certain scenarios#11stormageddon wants to merge 7 commits intojchen1:masterfrom
stormageddon wants to merge 7 commits intojchen1:masterfrom
Conversation
added 7 commits
November 18, 2016 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases, the album artwork of a song can take a while to load. When this happens, 2 notifications are shown: 1 with the last songs artwork, and 1 with the correct artwork. This fix ensures that in these scenarios only the second notification is shown.
There is probably a better way to do this, so if there is feel free to let me know the best way to fix this particular issue.