Fix IndexError on Jython (#250) #274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jython has an unfortunate issue where the socketaddr object isn't really a tuple, but is instead an item that acts like a tuple under some circumstances. This commit makes httplib2 convert it to an actual tuple, so that it will work as expected. This solution isn't very nice, but without upstream fixes to Jython, this is the only obvious solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jython has an unfortunate issue where the socketaddr object isn't really a tuple, but is instead an item that acts like a tuple under some circumstances. This commit makes httplib2 convert it to an actual tuple, so that it will work as expected.
This solution isn't very nice, but without upstream fixes to Jython, this is the only obvious solution. No hard feelings if you don't want to pull this one, but it would save me some headache in our Jython environments.