Add DictionaryViewModel with centralized action handling #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add database migration to clean up empty transcription records - Prevent saving empty/whitespace-only transcriptions in HistoryStorage - Add instant recording mode (0ms hold duration option) - Fix Keychain permission dialog appearing on app launch by using hasAPIKeyWithoutFetch() to check for stored keys without retrieving - Improve indicator state handling with isTransient check - Increase minimum window size to 900x600 - Add accent color tint to Toggle controls - Add tests for empty record skipping behavior Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create DictionaryViewModel with @observable pattern - Centralized performAction error handler for async operations - Computed properties: filteredTerms, isEmpty, hasNoSearchResults, isAtLimit, termCountLabel - Actions: addTerm, updateTerm, toggleTerm, deleteTerm, clearSearch, dismissError - Update DictionaryView to use ViewModel with State(initialValue:) init pattern - Add 18 comprehensive tests for DictionaryViewModelTests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DictionaryViewModelwith@Observablepattern following Store → ViewModel → UI architectureperformActionerror handler for async operations with automatic error displayDictionaryViewto use ViewModel withState(initialValue:)init pattern to avoid view flickerDictionaryViewModelTestsChanges
DictionaryViewModel (
TalkFlow/Features/Dictionary/DictionaryViewModel.swift):filteredTerms,isEmpty,hasNoSearchResults,isAtLimit,termCountLabeladdTerm,updateTerm,toggleTerm,deleteTerm,clearSearch,dismissErrorshowingErroranderrorMessageDictionaryView (
TalkFlow/UI/Dictionary/DictionaryView.swift):State(initialValue:)pattern in init to avoid ViewModel flickerTest plan
🤖 Generated with Claude Code