Skip to content

Conversation

@am1t
Copy link

@am1t am1t commented Feb 2, 2018

IndieWeb is a trending project, focused mainly on allowing website owners to own and control their content, and also stay connected with engagement on them across services. All it needs is availability of some key classes on elements. This does not need any action on user's part, at the same time enabling below.

  • Set up web sign-in via rel-me
  • Add info about owner via h-card
  • Add microformats to content via h-entry
  • Allow configuring webmention endpoint

am1t added 2 commits February 2, 2018 20:24
- Set up web sign-in via rel-me
- Add info about owner via h-card
- Add microformats to content via h-entry
@jbub jbub self-assigned this May 27, 2018
Copy link
Owner

@jbub jbub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, just a simple fix and we are ready to merge it :)

class="p-name u-url url author metatag" rel="me">
{{ .Site.Author.name }}
</a> /
<a class="p-nickname u-email email metatag" rel="me"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if Site.Author.nick and Site.Author.email are set and only then render this block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think this check would be important. I will incorporate the change and resubmit. Thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a check for this and made a new commit.

Added check for Site.Author.nick and Site.Author.email being set set. Only if they are set to a non-empty value, the relevant block will be rendered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants