Show options menu after downloads complete regardless of startu… #1466
Conversation
|
It does not show the UI post-run when using This is a nice idea but UI should never be shown when using I also think there should be different UI post-download with options such as hashing the current download run, deduplicating, retrying failed downloads/scrapes from the current run, etc. |
NTFSvolume
left a comment
NTFSvolume
left a comment
There was a problem hiding this comment.
I don't like this behavior. This means CDL will now always need human interaction to exit. You will not be able to use it in a script or any kind of automation.
It would be trivial for the user to just run CDL in an infinite loop if the want to see the UI again after a run.
At minimum it should be ignored with --download or any of the other options that disables the UI (all the retry options, the no ui options and simplified ui options)
| # Always show the interactive Program UI after downloads finish so the user | ||
| # can continue (for example re-run downloads or edit configs). If the user | ||
| # selects the download action in the UI we re-insert the current config | ||
| # at the front of `configs_to_run` to run it again. | ||
| if not manager.states.SHUTTING_DOWN.is_set(): | ||
| try: | ||
| ui = ProgramUI(manager, run=False) | ||
| # Run the blocking UI code in a thread so it doesn't interfere with the | ||
| # manager's asyncio event loop. This prevents prompt_toolkit/Application | ||
| # coroutine warnings when called from an active loop. | ||
| ui_result = await asyncio.to_thread(ui.run) | ||
| except SystemExit: | ||
| # user chose to exit from the UI | ||
| raise | ||
| except Exception: | ||
| # if UI fails for any reason, do not crash the director — continue shutdown | ||
| ui_result = False | ||
| else: | ||
| if ui_result: | ||
| configs_to_run.insert(0, current_config) |
There was a problem hiding this comment.
This will break if the user switched to a new config on the new UI or created a new one.
I would rather leave it as is, completely destroy the current manager and re-run the director from scratch
There was a problem hiding this comment.
There also needs to be an "enter to continue" just before that to make sure the stats show up on the terminal
| - `ProgramUI.run()` is now invoked from the director using a thread (`asyncio.to_thread`) | ||
| to avoid prompt_toolkit coroutine warnings when running inside the program's async | ||
| runtime. | ||
|
|
||
| - `cyberdrop_dl.__init__` now falls back to a local version string when distribution | ||
| metadata is not available. This makes running from a development checkout more | ||
| convenient (no editable install required to start the program). | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Prevent a "coroutine was never awaited" RuntimeWarning when invoking the TUI from | ||
| the running event loop. |
There was a problem hiding this comment.
These are too specific
| - `ProgramUI.run()` is now invoked from the director using a thread (`asyncio.to_thread`) | |
| to avoid prompt_toolkit coroutine warnings when running inside the program's async | |
| runtime. | |
| - `cyberdrop_dl.__init__` now falls back to a local version string when distribution | |
| metadata is not available. This makes running from a development checkout more | |
| convenient (no editable install required to start the program). | |
| ### Fixed | |
| - Prevent a "coroutine was never awaited" RuntimeWarning when invoking the TUI from | |
| the running event loop. |
3 participants
This PR makes the following changes:
--downloaddirector.pyto present UI options after any download run completes