Add ICAO code and utf-8 encoded airport names#2
Open
jmbredal wants to merge 1 commit intojbrooksuk:masterfrom
Open
Add ICAO code and utf-8 encoded airport names#2jmbredal wants to merge 1 commit intojbrooksuk:masterfrom
jmbredal wants to merge 1 commit intojbrooksuk:masterfrom
Conversation
Owner
|
Sorry for the delay on this. Would you be able to rebase against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I used this file in a private project, and noticed that the names of airports seemed to be set to null for airports with special characters in the name. As I needed that, I scraped wikipedia for names and ICAO codes and merged the results with airports.json based on the IATA code. Thus this pull-request contains updated utf-8 encoded names and added ICAO-codes for the airports with IATA-codes that I found on wikipedia.