Open
Conversation
david-poindexter
approved these changes
Aug 12, 2020
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
Looks good @hismightiness - it will be nice to use this project again!
bdukes
reviewed
Aug 12, 2020
bdukes
reviewed
Aug 12, 2020
| </glimpse> | ||
| </node> | ||
| <node path="/configuration/glimpse" action="update" targetpath="/configuration/glimpse/tabs" collision="ignore"> | ||
| <node path="/configuration/glimpse" action="update" targetpath="/configuration/glimpse/tabs" collision="overwrite"> |
Collaborator
There was a problem hiding this comment.
Why the change to overwrite?
Contributor
Author
There was a problem hiding this comment.
If you reinstall, it adds it a second time, crashing the site.
Collaborator
|
Have you tested that this doesn't cause an issue with sites that aren't using EF at all? Or site's using EF5? |
Collaborator
|
From what I recall of how these worked, I think the answer that's most compatible is just removing |
Contributor
Author
|
The Ado DLL is using EF5, causing the site to crash. You have to explicitly add the EF6 DLL to prevent this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.