Adding support for Pytorch 2.x and Pytorch-Lightning 2.0.7#151
Open
YankoFelipe wants to merge 1 commit intojbohnslav:masterfrom
Open
Adding support for Pytorch 2.x and Pytorch-Lightning 2.0.7#151YankoFelipe wants to merge 1 commit intojbohnslav:masterfrom
YankoFelipe wants to merge 1 commit intojbohnslav:masterfrom
Conversation
Removing deprecated param in pl.Trainer Setting pytorch_lightning version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for the cool pipeline. I was facing some crashes when I tried to run the code with PyTorch 2.x and PyTorch Lightning 2.0.7 so I fixed them. I used the nightly of 2.1 but it should be the same behaviour for the 2.0 release.
I was able to run the complete flow of Colab notebook and passed all the tests. The environment used was:
The Python version was
3.9.7and here are the result of the tests:I think it'll be complicated to merge this considering that there're no releases of DeepEthogram and that could mess the installation in environments with 1.x but it can be helpful for those working with PyTorch 2.x.