Skip to content

Fix the unwanted line on non-host room#69

Open
acarcher wants to merge 4 commits intojbkuczma:developfrom
acarcher:acarcher-collab
Open

Fix the unwanted line on non-host room#69
acarcher wants to merge 4 commits intojbkuczma:developfrom
acarcher:acarcher-collab

Conversation

@acarcher
Copy link
Copy Markdown

@acarcher acarcher commented Oct 23, 2017

References #55, I changed the class of the div from "card" to "row d-flex justify-content-center"

@acarcher acarcher closed this Oct 30, 2017
@acarcher acarcher changed the title Create activity.txt Fix the unwanted line on non-host room Oct 30, 2017
@acarcher acarcher reopened this Oct 30, 2017
@Rmiller1673
Copy link
Copy Markdown
Collaborator

The code you added takes away the line for the non-host room page, however for the host of the room the the new div causes the host room "Up Next" column to be disrupted in size. Please find below a screenshot of the host room page with the disrupted "Up Next" length for header of the column:

collab_for_ourproject_looks_incorrect_li

@acarcher
Copy link
Copy Markdown
Author

acarcher commented Nov 6, 2017

Thanks for pointing that out; the updated PR should reflect a correct change to the the_room.handlebars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants