added support for accessing an authenticated server#2
Open
vsoltan wants to merge 4 commits intojbaudoux:ospi-mqttfrom
vsoltan:auth-mqtt
Open
added support for accessing an authenticated server#2vsoltan wants to merge 4 commits intojbaudoux:ospi-mqttfrom vsoltan:auth-mqtt
vsoltan wants to merge 4 commits intojbaudoux:ospi-mqttfrom
vsoltan:auth-mqtt
Conversation
added 4 commits
May 19, 2020 19:35
…lied credentials. Still, there are issues with subscription where it periodically fails to do so. Toggling manual program still a work in progress.
… implemented proof-of-concept for running a manual program via mqtt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw some folks in the comments requesting this feature. Added optional parameters to the begin function to specify username and password. Tested this on both secure and insecure mosquitto server: seems like everything is working as it did before and authentication is working as expected. I haven't been able to verify this working on Arduino as my unit hasn't arrived yet (also can't compile demo because of library incompatibility). Let me know if there are any issues or something you would like changed!