Open
Conversation
Enhance scp.py to make the bahaviors to be identical to native scp command behaviors: 1. When meets non-regular files, scp.py should prompt. 2. After prompt, scp.py should continue to copy other remaining non-regular files.
Collaborator
|
Please stop sending PRs over and over. You can update an existing one. |
Author
|
Ok. Thanks. But really sorry about that. |
Author
|
Any comment on code change? Thanks! |
Collaborator
|
I'm worried that this will ignore too many errors, not just the "non-regular file" errors. At the minimum this should be configurable, and it would be great to have tests. |
Author
|
When copying directories, native scp command ignores all the non-regular file errors. But there is error log on this. The key point is that native scp command can continue to copy all the regular files in the remaining files under this folder. For recursive case, what are the other error code values (normally, they are C, T, D and E) when non-regular files are met? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance scp.py to make the bahaviors to be identical to native scp command behaviors: