Skip to content

add more blocks#8

Open
huanz wants to merge 4 commits intojballant:masterfrom
huanz:master
Open

add more blocks#8
huanz wants to merge 4 commits intojballant:masterfrom
huanz:master

Conversation

@huanz
Copy link

@huanz huanz commented Jun 14, 2017

No description provided.

@jballant
Copy link
Owner

Thanks for the PR. I like the idea of supporting different comment syntaxes for different file types, though I'm not sure it's necessary to also support multiple block declarations. You could just add rules for each block you want to strip.

Maybe something like this? It would not be a breaking change:

options: {
      start: 'DEV-START',
      end: 'DEV-END'
      commentStart: '/*', // defaults to '/*'
      commentEnd: '*/' // defaults to '*/'
}

Also, I can't merge this with the url for the repo being changed. I assume you are publishing your fork, so folks can use that while I mull over how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants