Skip to content

Fixes NPE when spam clicking right click with a chisel #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheFifthRider wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes NPE when spam clicking right click with a chisel #110

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b99ae53
fix: NPE when spam clicking right click with a chisel. This should be…
TheFifthRider Oct 30, 2025
a034385
style: Revert accidental whitespace
TheFifthRider Oct 30, 2025
8c66c9d
style: Revert accidental whitespace
TheFifthRider Oct 30, 2025
5fdc9a7
style: Remove unused imports
TheFifthRider Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion SmithingPlus/BitsRecovery/CollectibleBehaviorScrapeCrucible.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public override bool OnHeldInteractStep(float secondsUsed, ItemSlot slot, Entity
public override void OnHeldInteractStop(float secondsUsed,
ItemSlot slot,
EntityAgent byEntity,
BlockSelection blockSel,
BlockSelection? blockSel,
EntitySelection entitySel,
ref EnumHandling handling)
{
Expand All @@ -48,6 +48,7 @@ public override void OnHeldInteractStop(float secondsUsed,
if (byEntity.World.Side == EnumAppSide.Server)
{
if (byEntity is not EntityPlayer entityPlayer) return;
if (blockSel?.Position is null) return;
var groundStorage = TryGetSelectedGroundStorage(entityPlayer, blockSel);
if (!TryGetCrucibleStack(entityPlayer, blockSel, out var crucibleSlot) ||
crucibleSlot?.Itemstack is not { } crucibleStack)
Expand Down